Fix RestClient proxy path to preserve ProxyManager behavior#221
Closed
NguyenHoangSon96 with Copilot wants to merge 3 commits into
Closed
Fix RestClient proxy path to preserve ProxyManager behavior#221NguyenHoangSon96 with Copilot wants to merge 3 commits into
NguyenHoangSon96 with Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code for review comment
Fix RestClient proxy path to preserve ProxyManager behavior
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the single review thread requesting a fix for proxy handling in
RestClient. The previous implementation replacedProxyManagerwith a host-scoped connection pool, which bypassed manager-level proxy behavior (CONNECT/proxy headers).What changed
RestClient.__init__now storesurllib3.ProxyManager/urllib3.PoolManagerdirectly instead of calling.connection_from_url(...).RestClient.request(...)now builds an absolute URL frombase_url + path(for relative paths) and sends that URL viapool_manager.request(...).Targeted test coverage
RestClientkeeps the manager instance and issues requests with an absolute URL.