DateTimeController: Fix build with libc++#2456
Open
JoeStrout wants to merge 1 commit into
Open
Conversation
std::chrono::system_clock::to_time_t() takes a time_point specialized on the clock's own duration type. With libstdc++, system_clock::duration is nanoseconds, so passing currentDateTime (explicitly declared as time_point<system_clock, nanoseconds>) matches exactly and compiles. With libc++, system_clock::duration is microseconds, and so the call fails to compile. This breaks the build of the InfiniSim simulator on macOS, where Apple clang uses libc++. CI does not catch it because the simulator is only built on Linux. This change casts the time_point to the clock's duration before the call, which is already what AlarmController.cpp and WatchFaceCasioStyleG7710.cpp do at their equivalent call sites. This is an identity cast with libstdc++, so the firmware build is unaffected; with libc++ it truncates nanoseconds to microseconds, which is irrelevant because to_time_t truncates to whole seconds anyway. So, this change should have no effect other than enabling InfiniSim to build successfully on macOS.
|
Build size and comparison to main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::chrono::system_clock::to_time_t() takes a time_point specialized on
the clock's own duration type. With libstdc++, system_clock::duration is
nanoseconds, so passing currentDateTime (explicitly declared as
time_point<system_clock, nanoseconds>) matches exactly and compiles. With
libc++, system_clock::duration is microseconds, and so the call fails to
compile.
This breaks the build of the InfiniSim simulator on macOS, where Apple
clang uses libc++. CI does not catch it because the simulator is only
built on Linux.
This change casts the time_point to the clock's duration before the call,
which is already what AlarmController.cpp and WatchFaceCasioStyleG7710.cpp
do at their equivalent call sites. This is an identity cast with libstdc++,
so the firmware build is unaffected; with libc++ it truncates nanoseconds
to microseconds, which is irrelevant because to_time_t truncates to whole
seconds anyway.
So, this change should have no effect other than enabling InfiniSim to
build successfully on macOS.