Remove workflow_dispatch to fix CodeQL cache poisoning - #73
Merged
Conversation
The E2E workflow was flagged by CodeQL (actions/cache-poisoning/poisonable-step) because the workflow_dispatch trigger has write access to the shared cache scope while the job executes untrusted code (Robin checkout from a PR-controlled ref). Drop workflow_dispatch and keep only pull_request, which scopes the cache to the PR branch (the pattern CodeQL considers safe), closing all three alerts. With the risky trigger gone, re-enable the Go cache (cache: true) for faster PR runs. On-demand runs are still possible via a draft PR, and the target Robin branch can be selected with a 'robin-ref:' line in the PR body. Parallelism is now driven by the E2E_TEST_PARALLEL_PROCESSES repository variable (defaults to 2), and the dead github.sha fallback in the concurrency group is removed. Signed-off-by: Alberto Martínez Pérez <albertompe@ext.inditex.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The E2E workflow was flagged by CodeQL (actions/cache-poisoning/poisonable-step) because the workflow_dispatch trigger has write access to the shared cache scope while the job executes untrusted code (Robin checkout from a PR-controlled ref).
Drop workflow_dispatch and keep only pull_request, which scopes the cache to the PR branch (the pattern CodeQL considers safe), closing all three alerts. With the risky trigger gone, re-enable the Go cache (cache: true) for faster PR runs.
On-demand runs are still possible via a draft PR, and the target Robin branch can be selected with a 'robin-ref:' line in the PR body. Parallelism is now driven by the E2E_TEST_PARALLEL_PROCESSES repository variable (defaults to 2), and the dead github.sha fallback in the concurrency group is removed.
Checklist
git commit -S)