Adds the option to throw an exception on missing parameters #107
Open
silvant wants to merge 3 commits into
Open
Adds the option to throw an exception on missing parameters #107silvant wants to merge 3 commits into
silvant wants to merge 3 commits into
Conversation
stof
requested changes
Jan 18, 2017
stof
left a comment
stof
left a comment
Member
There was a problem hiding this comment.
this needs to be covered by tests
| { | ||
| // Simply use the expectedParams value as default for the missing params. | ||
| if (!$this->io->isInteractive()) { | ||
| if (isset($config['exception-when-missing'])) { |
Member
There was a problem hiding this comment.
this should check the value of the config too. Setting it to false should not throw
Author
There was a problem hiding this comment.
Agree, I chose isset, as that is similar as keep-outdated. Recommend we change both them to !empty && Inline::parse !== false. Do you agree?
silvant
force-pushed
the
excep-missing-params
branch
2 times, most recently
from
664d7e8 to
c906e51
Compare
…missing is true, and combines dist when exception-when-missing is false
silvant
force-pushed
the
excep-missing-params
branch
from
c906e51 to
111e111
Compare
Author
|
So apparently the Scrutinizer success result doesn't register here. Does somebody know how to fix this? |
|
Any news about this feature ? I'm also very interested |
|
This one should be closed as duplicate in favor of #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in non-interactive mode, fixes #105