perf(supertypes): add global super type cache#808
Open
Skullians wants to merge 1 commit intoIncendo:masterfrom
Open
perf(supertypes): add global super type cache#808Skullians wants to merge 1 commit intoIncendo:masterfrom
Skullians wants to merge 1 commit intoIncendo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same justifications as my other PR:
The repeated calls to isSuperType were getting a little heavy, so I've taken the liberty of adding this global cache to cloud-core...
I've also moved some calls to the new cache on cloud-core itself (not necessarily appearing on the above image of spark), but thought it would be a nice idea anyways
isSuperType is used in a decent few platforms so it made the most sense to do a cache in the core and then I can PR it into the other respective repos🤔