Ipetrov/wc grid skill - #2376
Open
ivanvpetrov wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new skill includes incorrect/ambiguous tool-parameter guidance that can cause agents to call MCP tools with the wrong argument names.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new end-user “grids” skill to the skills/ catalog to guide consistent Ignite UI Web Components grid setup and troubleshooting, with emphasis on theming (including Shadow DOM), component registration, layout sizing, and basic sorting/filtering enablement.
Changes:
- Adds a new
igniteui-wc-gridsskill documenting grid/package selection, theming imports, Shadow DOM theme injection, and layout guidance. - Updates the skills index (
skills/README.md) to include the new grids skill.
File summaries
| File | Description |
|---|---|
| skills/README.md | Adds the new grids skill to the published skills list. |
| skills/igniteui-wc-grids/SKILL.md | Introduces a new skill covering grid setup, theming, Shadow DOM injection, layout, and sorting/filtering. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ## Required Workflow | ||
|
|
||
| 1. **Pick the grid type/package** using the table below; ask if ambiguous. | ||
| 2. **Use only the verified import paths in this file** (`grids/combined.js`, `themes/<variant>/<design>.css`). For anything else (toolbar, export, pivot/tree/hierarchical APIs, properties/events), look it up with `list_components` / `search_api` / `get_doc` / `get_api_reference` (`platform: "webcomponents"`) instead of guessing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a basic skill about grids to igniteui.WebComponents, similar to what we have in React and Angular already.
Needs to fix known style import issues and improve agent grid generation.
Type of Change
Related Issues
Closes #
Testing
Checklist