chore(igc-ts): remove non-functional npmrc file#1671
Open
damyanpetev wants to merge 2 commits intomasterfrom
Open
chore(igc-ts): remove non-functional npmrc file#1671damyanpetev wants to merge 2 commits intomasterfrom
damyanpetev wants to merge 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a redundant .npmrc from the igc-ts Web Components base project template, aligning the template with how dotfiles are handled/packaged and relying on existing update logic to create .npmrc when required.
Changes:
- Deleted
packages/cli/templates/webcomponents/igc-ts/projects/_base/files/.npmrcfrom the base template.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
coverage: 86.279%. remained the same — dpetev/wc-redundant-npmrc into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed redundant npmrc file since it's both outdated in content and it doesn't work since it's not packages (not
__dot__prefixed) and the update logic adds this when needed.Type of Change
Affected Packages
igniteui-cli(packages/cli)@igniteui/cli-core(packages/core)@igniteui/angular-templates(packages/igx-templates)@igniteui/angular-schematics(packages/ng-schematics)@igniteui/mcp-server(packages/igniteui-mcp)Checklist
npm run test)npm run build)npm run lint)Additional Context