-
Notifications
You must be signed in to change notification settings - Fork 8
Make ig ai-config agent-agnostic instead of hard-coding .claude/skills
#1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
18
commits into
master
Choose a base branch
from
copilot/update-ai-config-agent-agnostic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
52cd22f
Initial plan
Copilot 2c18475
feat: make ai-config agent-agnostic with --agent and --skills-dir opt…
Copilot c67709e
refactor: improve analytics event and clean up skillsDir resolution
Copilot d4478a9
feat: update angular schematics ai-config to accept --agent and --ski…
Copilot 5784c4a
feat: enhance ai-config to prompt for agent selection and improve ski…
Marina-L-Stoyanova 39eff3d
feat: enhance ai-config command to handle agent selection and improve…
Marina-L-Stoyanova 6c5d717
feat: make ai-config agent-agnostic by supporting multiple agents and…
Marina-L-Stoyanova 14e062d
feat: refactor ai-config to support agent-based skills configuration …
Marina-L-Stoyanova 026fb9e
Merge branch 'master' of https://github.com/IgniteUI/igniteui-cli int…
Marina-L-Stoyanova 3669211
feat: add AI agent configuration options to project creation
Marina-L-Stoyanova f2f39a9
change():Moving skills to ai-config skills directory and updating the…
Marina-L-Stoyanova 1379243
chore: enhance AI configuration options with labels and improved sele…
Marina-L-Stoyanova 4fb65da
feat: update AI configuration options to include 'none' and improve p…
Marina-L-Stoyanova baee30a
feat: enhance AI configuration by adding instruction file handling an…
Marina-L-Stoyanova 56ccdf8
Removing skills and instructions from _base templates
Marina-L-Stoyanova 96f010b
Optimizing react ai-config template
Marina-L-Stoyanova 9ca5b16
fix: remove unnecessary whitespace in PromptSession unit tests
Marina-L-Stoyanova 100f1e4
chore: remove outdated AGENTS.md file from React template
Marina-L-Stoyanova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
packages/cli/templates/react/igr-ts/projects/_base/files/__dot__claude/CLAUDE.md
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...mplates/react/igr-ts/projects/_base/files/__dot__github/copilot-instructions.md
This file was deleted.
Oops, something went wrong.
File renamed without changes.
50 changes: 50 additions & 0 deletions
50
packages/cli/templates/react/igr-ts/projects/ai-config/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import { ControlExtraConfiguration, defaultDelimiters, ProjectTemplate, updateWorkspace, Util } from "@igniteui/cli-core"; | ||
| import * as path from "path"; | ||
|
|
||
| export class BaseIgrTsAiConfigPartial implements ProjectTemplate { | ||
| public id: string = "ai-config"; | ||
| public name = "ai-config"; | ||
| public description = "Ignite UI CLI project for React"; | ||
| public framework: string = "react"; | ||
| public projectType: string = "tsx"; | ||
| public dependencies: string[]; | ||
| public hasExtraConfiguration: boolean = false; | ||
| public isHidden: boolean = true; | ||
| public delimiters = defaultDelimiters; | ||
|
|
||
| public get templatePaths(): string[] { | ||
| return [path.join(__dirname, "files")]; | ||
| } | ||
|
|
||
| public generateConfig(name: string, theme: string, ...options: any[]): {[key: string]: any} { | ||
| return this.getVariablesConfig(name, theme); | ||
| } | ||
|
|
||
| public installModules(): void { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| public async upgradeIgniteUIPackages(projectPath: string, packagePath: string): Promise<boolean> { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| public getExtraConfiguration(): ControlExtraConfiguration[] { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| public setExtraConfiguration(extraConfigKeys: {}) { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
|
|
||
| protected getVariablesConfig(name: string, theme: string) { | ||
| return { | ||
| name, | ||
| theme, | ||
| "cliVersion": Util.version(), | ||
| "dash-name": Util.lowerDashed(name), | ||
| "description": this.description, | ||
| "dot": ".", | ||
| "path": name, | ||
| "projectTemplate": this.id, | ||
| "yamlDefaultBranch": this.id === "base" ? "<%=yaml-default-branch%>" : "main" | ||
| }; | ||
| } | ||
| } | ||
| export default new BaseIgrTsAiConfigPartial(); |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
3 changes: 0 additions & 3 deletions
3
...cli/templates/webcomponents/igc-ts/projects/_base/files/__dot__claude/CLAUDE.md
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...webcomponents/igc-ts/projects/_base/files/__dot__github/copilot-instructions.md
This file was deleted.
Oops, something went wrong.
File renamed without changes.
38 changes: 38 additions & 0 deletions
38
packages/cli/templates/webcomponents/igc-ts/projects/ai-config/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { ControlExtraConfiguration, ProjectTemplate, TemplateDelimiters } from "@igniteui/cli-core"; | ||
| import * as path from "path"; | ||
|
|
||
| export class BaseIgcTsAiConfigPartial implements ProjectTemplate { | ||
|
|
||
| public id: string = "ai-config"; | ||
| public name = "ai-config"; | ||
| public description = "Project structure with routing"; | ||
| public framework: string = "webcomponents"; | ||
| public projectType: string = "igc-ts"; | ||
| public dependencies: string[]; | ||
| public hasExtraConfiguration: boolean = false; | ||
| public isHidden: boolean = true; | ||
|
|
||
| public get templatePaths(): string[] { | ||
| return [path.join(__dirname, "files")]; | ||
| } | ||
|
|
||
| installModules(): void { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| upgradeIgniteUIPackages(projectPath: string, packagePath: string): Promise<boolean> { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| generateConfig(name: string, theme: string, ...options: any[]): { [key: string]: any; } { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| delimiters: TemplateDelimiters; | ||
| getExtraConfiguration(): ControlExtraConfiguration[] { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| setExtraConfiguration(extraConfigKeys: {}) { | ||
| throw new Error("Method not implemented."); | ||
| } | ||
| } | ||
| export default new BaseIgcTsAiConfigPartial(); | ||
|
|
||
|
|
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we roll that option into one thing? Kinda odd to be able to pass both - like
--agent claude --dir .github/skills