Skip to content

fix(grid): ensure resize observer is only created if available in ssr - 21.2.x - #17500

Merged
ChronosSF merged 1 commit into
21.2.xfrom
mdragnev/fix-17497-21.2.x
Aug 14, 2026
Merged

fix(grid): ensure resize observer is only created if available in ssr - 21.2.x#17500
ChronosSF merged 1 commit into
21.2.xfrom
mdragnev/fix-17497-21.2.x

Conversation

@mddragnev

Copy link
Copy Markdown
Member

Closes #17497

Description

Motivation / Context

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Test Configuration:

  • Angular version:
  • Browser(s):
  • OS:

Screenshots / Recordings

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an SSR build-time crash triggered by the grid’s virtualization directive attempting to instantiate ResizeObserver when it isn’t available (e.g., during server-side rendering), aligning behavior with issue #17497.

Changes:

  • Guarded ResizeObserver instantiation in IgxGridForOfDirective.ngOnInit() by checking getResizeObserver() for availability first.
  • Prevented server/runtime errors in environments where window.ResizeObserver is undefined.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@viktorkombov viktorkombov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Aug 12, 2026
@ChronosSF
ChronosSF merged commit 91d4849 into 21.2.x Aug 14, 2026
6 checks passed
@ChronosSF
ChronosSF deleted the mdragnev/fix-17497-21.2.x branch August 14, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

angular: ssr grid version: 21.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants