fix(elements): Ensure ForOF out of bound row gets deleted before moving to opposite side#17238
Open
fix(elements): Ensure ForOF out of bound row gets deleted before moving to opposite side#17238
Conversation
skrustev
added
❌ status: awaiting-test
skrustev
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a virtualization/state update issue affecting IgxForOfDirective (notably reproducible in Elements + Hierarchical Grid scenarios) that could lead to incorrect sizing/scroll behavior after view reuse.
Changes:
- Adjusts
IgxForOfDirectivescroll-swap logic to be more defensive and forces a view refresh (detectChanges) when reusing cached embedded views. - Updates an existing grid grouping spec to better reproduce/cover the virtualization scenario (scroll + cached row reuse).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/grid.groupby.spec.ts | Updates an async virtualization-related test sequence to stabilize/trigger the expected state restoration after scrolling. |
| projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts | Tweaks view-reuse logic during scroll swaps, adds extra change detection, and guards against missing embedded views. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17179
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Grids, ForOf
How Has This Been Tested?
Test Configuration:
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)