fix(hgrid): add and use lifecycle placeholder for grid connection eve…#17230
Open
MayaKirova wants to merge 3 commits intomasterfrom
Open
fix(hgrid): add and use lifecycle placeholder for grid connection eve…#17230MayaKirova wants to merge 3 commits intomasterfrom
MayaKirova wants to merge 3 commits intomasterfrom
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| </igx-grid-toolbar-actions> | ||
| </igx-grid-toolbar> | ||
| <igx-row-island [key]="'childData'" [autoGenerate]="true" [rowSelection]='selectionMode' [batchEditing]="true" [rowEditable]="true" | ||
| <igx-row-island [rowEditable]="true" [primaryKey]="'ID'" [key]="'childData'" [autoGenerate]="true" [rowSelection]='selectionMode' [batchEditing]="true" [rowEditable]="true" |
| <igx-row-island [rowEditable]="true" [primaryKey]="'ID'" [key]="'childData'" [autoGenerate]="true" [rowSelection]='selectionMode' [batchEditing]="true" [rowEditable]="true" | ||
| [allowFiltering]="true"> | ||
| <igx-row-island [key]="'childData'" [autoGenerate]="true" [rowSelection]='selectionMode' [batchEditing]="true" [rowEditable]="true" | ||
| <igx-row-island [rowEditable]="true" [primaryKey]="'ID'" [key]="'childData'" [autoGenerate]="true" [rowSelection]='selectionMode' [batchEditing]="true" [rowEditable]="true" |
damyanpetev
reviewed
Apr 24, 2026
|
|
||
| class IgxHierarchicalGridLifecyclePlaceholderElement extends HTMLElement { | ||
| public connectedCallback(): void { | ||
| this.dispatchEvent(new CustomEvent('igcConnected', { bubbles: true, composed: true })); |
Member
There was a problem hiding this comment.
With this specific usage, I think the events don't need to bubble at all (and even less be composed)
damyanpetev
reviewed
Apr 24, 2026
| } | ||
| } | ||
|
|
||
| customElements.define(HGRID_LIFECYCLE_PLACEHOLDER_TAG, IgxHierarchicalGridLifecyclePlaceholderElement); |
Member
There was a problem hiding this comment.
Also wouldn't mind this being shortened a bit (the name) and possibly be in a self contained file, but that's not critical
MayaKirova
added
❌ status: awaiting-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nts.
Closes #17229
Description
Add and use a native wc component as a placeholder to detect connect/disconnect events in hgrid.
Use the events to show/hide row edit overlay, since popover gets closed on detach.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
IgxHierarchicalGrid
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)