Skip to content

Fix: Icinga CA Importer should not import custom CA's into the cert store #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LordHepipud wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −0
Open

Fix: Icinga CA Importer should not import custom CA's into the cert store #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions doc/100-General/10-Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ documentation before upgrading to a new release.

Released closed milestones can be found on [GitHub](https://github.com/Icinga/icinga-powershell-framework/milestones?state=closed).

## 1.15.0 (2026-06-30)

[Issues and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/45)

### Bugfixes

* [#874](https://github.com/Icinga/icinga-powershell-framework/pull/874) Fixes Icinga CA importer to only import the CA from our "Icinga CA" into the Windows cert store, leaving custom CA's alone, as they are handled seperately on environments anyway.

## 1.14.2 (2026-03-31)

[Issues and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/44)
Expand Down
8 changes: 8 additions & 0 deletions lib/webserver/Test-IcingaCAInstalledToAuthRoot.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ function Test-IcingaCAInstalledToAuthRoot()

$IcingaCACert = New-Object Security.Cryptography.X509Certificates.X509Certificate2 $IcingaCAFile;

# If the issuer of our CA is not the "Icinga CA", always return true as this is a custom CA then.
# Generally speaking, custom CA's are handled properly anyway so this is the correct behavior.
if ($IcingaCACert.Issuer -ne 'CN=Icinga CA') {
$IcingaCACert = $null;

return $TRUE;
}

[bool]$IcingaCAInstalled = $FALSE;

Get-ChildItem -Recurse -Path 'Cert:\LocalMachine\AuthRoot\' | Where-Object {
Expand Down