Drop a per-call closure allocation in the bipermutedimsopadd! axis check#196
Merged
Conversation
## Summary Removes a per-call heap allocation in `check_input` for `bipermutedimsopadd!`. The axis check built its comparison tuple with `ntuple(d -> op(axes(src, perm[d])), ndims(dest))`, whose index closure captures runtime values (`op`, `src`, `perm`) and so is heap-allocated on every call. Mapping over the permutation tuple directly with `map(p -> op(axes(src, p)), perm)` is unrolled over the concrete tuple and allocates nothing, and is equivalent because `ndims(dest) == length(perm)` is already checked just above. A 2x2 `permutedimsadd!` drops from 2 allocations (64 B) to 1 (16 B).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
- Coverage 83.38% 83.07% -0.31%
==========================================
Files 22 22
Lines 650 650
==========================================
- Hits 542 540 -2
- Misses 108 110 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a per-call heap allocation in
check_inputforbipermutedimsopadd!. The axis check built its comparison tuple withntuple(d -> op(axes(src, perm[d])), ndims(dest)), whose index closure captures runtime values (op,src,perm) and so is heap-allocated on every call. Mapping over the permutation tuple directly withmap(p -> op(axes(src, p)), perm)is unrolled over the concrete tuple and allocates nothing, and is equivalent becausendims(dest) == length(perm)is already checked just above. A 2x2permutedimsadd!drops from 2 allocations (64 B) to 1 (16 B).