Set up the benchmark suite#191
Merged
Merged
Conversation
## Summary Replaces the stale ITensorPkgSkeleton benchmark stub with a `BenchmarkTools` suite covering the core contraction entry points (`contract`, `contract!`) across a range of dimensions, so a regression shows up in both the small-tensor regime (dominated by the per-call label bookkeeping) and the large one (dominated by the BLAS call). The suite exposes the `SUITE` global that `AirspeedVelocity.jl`'s `benchpkg` expects, and `benchmark/README.md` documents running it directly and comparing revisions. The suite is also run once as a smoke test in the package tests, so it cannot silently fall out of sync with the API the way the stub had (it still called the long-removed `default_contract_alg`).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 82.62% 82.30% -0.33%
==========================================
Files 22 22
Lines 616 616
==========================================
- Hits 509 507 -2
- Misses 107 109 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the stale ITensorPkgSkeleton benchmark stub with a
BenchmarkToolssuite covering the core contraction entry points (contract,contract!) across a range of dimensions, so a regression shows up in both the small-tensor regime (dominated by the per-call label bookkeeping) and the large one (dominated by the BLAS call). The suite exposes theSUITEglobal thatAirspeedVelocity.jl'sbenchpkgexpects, andbenchmark/README.mddocuments running it directly and comparing revisions.The suite is also run once as a smoke test in the package tests, so it cannot silently fall out of sync with the API the way the stub had (it still called the long-removed
default_contract_alg).