[PATCH] Drop redundant tag triggers from CI; restrict docs to v* tags#25
Merged
[PATCH] Drop redundant tag triggers from CI; restrict docs to v* tags#25
Conversation
mtfishman
changed the title
mtfishman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test and integration-test workflows currently re-run on every tag push. The same commit was already tested on merge to
main, and tags fire after registration — re-running adds no signal. Documentation keeps tag triggering for Documenter.jl's versioned-docs flow but restricts tov*so subdir-package tags don't pollute the docs build.Background
The original PkgTemplates.jl design ships a single combined CI workflow where
tags: '*'was needed so Documenter.jl's versioned-docs deploy job would fire on tag pushes. Splitting tests and docs into separate workflow files inherited the trigger block on both sides, so the test workflows have been firing on every tag push as a side-effect rather than for any active reason.This PR mirrors the corresponding skeleton change in ITensorPkgSkeleton.jl#132.
Changes
Tests.ymltags: "*"IntegrationTest.ymltags: "*"Documentation.ymltags: "*"→tags: ["v*"]