Route Index and NamedUnitRange constructors through to_range#190
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 72.77% 72.70% -0.07%
==========================================
Files 28 28
Lines 1480 1484 +4
==========================================
+ Hits 1077 1079 +2
- Misses 403 405 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mtfishman
force-pushed
the
mf/to_range
branch
4 times, most recently
from
d94f4e4 to
479804b
Compare
## Summary
Routes the `NamedUnitRange{Name}` length argument, and so `Index`, through `to_range` (introduced in ITensor/TensorAlgebra.jl#189), collapsing the separate integer and range constructors into one. `Index` now uniformly accepts an integer, an existing range, or, with GradedArrays loaded, a vector of sector-to-multiplicity pairs like `Index([U1(0) => 2, U1(1) => 3])`. This adds no dependency on GradedArrays: `to_range` dispatches on the spec type, and a caller writing the sector form already has GradedArrays loaded.
mtfishman
changed the title
Index and NamedUnitRange constructors through to_rangeIndex and NamedUnitRange constructors through to_range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routes the
NamedUnitRange{Name}constructor argument, and soIndex, throughto_range(introduced in ITensor/TensorAlgebra.jl#189), so the same constructor accepts an integer, an existing range, or, with GradedArrays loaded, a vector of sector-to-multiplicity pairs likeIndex([U1(0) => 2, U1(1) => 3]). This adds no dependency on GradedArrays:to_rangedispatches on the argument type, and a caller writing the sector form already has GradedArrays loaded.