feat(elt-pipelines): Port opralogweb pipeline to elt - #414
Conversation
📝 WalkthroughWalkthroughAdds an OPRA logbook database extractor with table watermarking, merge/upsert configuration, entry-linked related-column queries, HTML-to-Markdown comment conversion, and optional runtime dependencies. ChangesOPRA logbook extraction
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@elt-pipelines/facility_ops/ingest/accelerator/opralogweb/opralogweb.py`:
- Around line 32-55: Update the resource generator around the Entries and
MoreEntryColumns ResourceProperties so each deferred extractor opens and owns
its database connection when invoked, rather than capturing conn from the
enclosing with block. Ensure _extract_entries and _extract_more_entry_columns
execute while their respective connections remain open, and remove the outer
connection scope that closes before iteration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8d27adaa-669b-479e-a598-603701455a60
⛔ Files ignored due to path filters (1)
elt-pipelines/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
elt-pipelines/facility_ops/ingest/accelerator/opralogweb/opralogweb.pyelt-pipelines/pyproject.toml
|
Forgot to add, env variables should be:
|
ref #321
Ports the opralogweb pipeline to
elt-pipelines.