feat(reports): Using Superset as reporting tool frontend#316
Conversation
Document decision to use Superset as the frontend replacement for the reporting tool, detailing evaluation criteria and outcomes.
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR introduces ADR 0008, documenting the decision to adopt Apache Superset as the reporting-tool frontend. The decision compares Superset and Metabase across evaluation criteria and selects Superset based on superior authentication and identity integration alignment. ChangesSuperset Selection ADR
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs-devel/system-architecture/adrs/0008-use-superset-as-reporting-tool-frontend.md`:
- Around line 18-23: Change the Decision section from future to past tense to
reflect that the evaluation already occurred: replace the opening sentence "We
will evaluate both Apache Superset and Metabase as potential frontend
replacements for the legacy reporting tool." with a past-tense variant like "We
evaluated both Apache Superset and Metabase as potential frontend replacements
for the legacy reporting tool." and update any supporting verbs in the bullet
list to past tense (e.g., "This evaluation was conducted locally" and "Assess
and compare" → "Assessed and compared") so the Decision block and its bullets
consistently reflect a completed evaluation; edit the block referenced as
"Decision" in the ADR document to apply these changes.
- Line 31: Locate the "Consequences" section in the ADR document and replace the
heading or label text "Final Outcome:" with the shorter "Outcome:" (search for
the exact string "Final Outcome:" to find the occurrence); ensure any internal
references or links that point to "Final Outcome" are updated to the new label
if present so consistency is preserved.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 078d1633-8b9f-4ada-8571-7bf4090dff77
📒 Files selected for processing (1)
docs-devel/system-architecture/adrs/0008-use-superset-as-reporting-tool-frontend.md
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 2 unresolved review comments. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 2 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
martyngigg
left a comment
There was a problem hiding this comment.
Thanks for this. It reads well and covers all the points.
Summary: Apache Superset Selected as Frontend
To enable analysis on lakehouse data extracted from the FASE application, the organization evaluated open-source BI tools Apache Superset and Metabase #283 across data modeling, visualization, RBAC, and authentication criteria.
While both platforms offer comparable data visualization and modeling features, internal security requirements heavily favored Apache Superset. The organization’s analytics platform mandates centralized identity integration (OIDC/SAML). The open-source version of Metabase only supports LDAP, API keys, and Google OAuth, failing internal standards. Choosing Superset ensures full compliance with institutional security architecture without sacrificing vital business intelligence capabilities.
Summary by CodeRabbit