Fix timing issue when posting guestbook response and requesting the d…#12341
Fix timing issue when posting guestbook response and requesting the d…#12341stevenwinship wants to merge 1 commit intodevelopfrom
Conversation
This comment has been minimized.
This comment has been minimized.
f8514a4 to
c3959ae
Compare
This comment has been minimized.
This comment has been minimized.
c3959ae to
a85e23f
Compare
This comment has been minimized.
This comment has been minimized.
a85e23f to
d0d1f3b
Compare
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
landreev
left a comment
There was a problem hiding this comment.
Makes sense overall. Should we make it a jvm setting, and configurable, in seconds? - Although I suspect that 1 min. will just work for everybody.
Your call really. Happy to approve as soon as I hear back either way. |
landreev
left a comment
There was a problem hiding this comment.
... or I can just approve. If/when someone has a practical need to reduce, or increase this lifespan, we'll deal with it.
|
The Jenkins failure is an aws fluke - ? |
Not an "aws fluke", but still, for reasons unrelated to/before it gets to the tests. |
|
OK, Jenkins tests passed. (thanks @donsizemore!) |
Which issue(s) this PR closes:#12340
Special notes for your reviewer:
Suggestions on how to test this: post guestbook response. loop calling api with signed url to make sure you can call download within the minute
[edit:] The old/incorrect behavior, currently in the develop branch:
0-10 sec.: the signed url is working as it should;
11-60 sec.: error message "you may not download this file without the required Guestbook response ..." (??)
60+sec: signed url expires.
[/edit - L.A.]
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: