Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts an integration test setup for CollectionsRepository around tabular file handling.
Changes:
- Updates the uploaded test tabular file name used by the
getCollectionItems for published tabular fileintegration test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| describe('getCollectionItems for published tabular file', () => { | ||
| let testDatasetIds: CreatedDatasetIdentifiers | ||
| const testTextFile4Name = 'test-file-4.tab' | ||
| const testTextFile4Name = 'test-file-4.tsv' |
There was a problem hiding this comment.
testTextFile4Name was changed to test-file-4.tsv, but the test fixture that uploadFileViaApi reads from test/testHelpers/files is test-file-4.tab (no .tsv exists). This will cause readFile(${__dirname}/${fileName}) to fail and also makes the later expectation expectedFileName = 'test-file-4.tab' inconsistent. Either revert to .tab or add the .tsv fixture and update the expected filename/assertions accordingly.
Suggested change
| const testTextFile4Name = 'test-file-4.tsv' | |
| const testTextFile4Name = 'test-file-4.tab' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There was a change on DV with IQSS/dataverse#12145 that caused tests to fail, this is meant to be a temporary patch since it seems there is a bug with this PR.
We did a few testing and provided a .tsv file and received .tab response.
When providing a .tab file we received a .tsv response.