Addition of AllowedDatasetTypes to Collection#441
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for returning a collection’s allowed dataset types as part of the Collection model, so clients (e.g., Create Dataset UI) can display which dataset types can be created in a collection.
Changes:
- Extended
CollectionandCollectionPayloadto includeallowedDatasetTypes. - Updated collection payload transformer to map
allowedDatasetTypesinto domainDatasetType[]. - Updated collection test helpers’ fixtures to include
allowedDatasetTypes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/testHelpers/collections/collectionHelper.ts | Updates mock Collection model/payload fixtures to include allowedDatasetTypes for unit tests. |
| src/collections/infra/repositories/transformers/collectionTransformers.ts | Transforms allowedDatasetTypes from API payload into domain DatasetType[]. |
| src/collections/infra/repositories/transformers/CollectionPayload.ts | Adds allowedDatasetTypes to the Collection API payload typing and defines AllowedDatasetTypePayload. |
| src/collections/domain/models/Collection.ts | Adds allowedDatasetTypes?: DatasetType[] to the Collection domain model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Closes Update Get Collection use case to include available dataset types #425
Depends on Setup TS change to allow skipping the containers setup. #440
This PR doesn't have a hard dependency, but merging #440 would make it easier to test.
Suggestions on how to test this:
Having a running dataverse installation and create a collection named REVIEW, then run the following script to configure it (Replace your api token):
Once this is done, use JS Dataverse to retrieve this collection.