Conversation
) Perf now takes func (a callable or list of callables) plus a BiB default, instead of separate score_func/error_func arguments. Direction still comes from a callable's own .BiB tag when present (e.g. set by metrics.py's .measure() factories), falling back to the constructor's BiB otherwise -- BiB remains the single source of truth, with no XOR-style dual-argument split to keep in sync. Fixes three call sites that had drifted out of sync by re-deriving direction from `score_func is not None` instead of the actual .BiB: Perf.statistic's sort order, Perf.__repr__'s label, and Perf.plot's default value_name. Updates all 26 metrics.py wrappers, utils.py's metrics_docs decorator, tests (plus 3 new regression tests for the fixed call sites), and docs accordingly. performance.py needs no changes -- its score_func is an unrelated local variable. Also normalizes whitespace across all .py files for PEP8 consistency: trailing whitespace, missing EOF newlines, and spacing around annotated defaults (e.g. `int=500` -> `int = 500`), applied via autopep8 restricted to whitespace-only codes plus a manual trailing-whitespace/EOF-newline pass. No logic changes; full test suite (74 tests) passes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…r el uso correcto de nombres de algoritmos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Perf/Difference(Plan: Multi-measure API for Perf/Difference (e.g. macro-F1 + macro-recall together) #30), with docs and doctest fixes (Document missing functions/features and add multi-measure examples (from #30) #32).score_func/error_funcsplit with a singlefunc+BiBflag onPerf, makingBiBthe sole source of truth for direction and fixing three internal call sites that silently ignored per-measure.BiBoverrides (Replace score_func/error_func with a single BiB flag on Perf #36).correction=— anystatsmodels.stats.multitest.multipletestsmethod) threaded throughDifference.p_value()/.dataframe()/.plot()andPerf.dataframe()/.plot(), so significance legends reflect corrected p-values, not just the raw numbers (Performance multiple comparison #35).Closes #30, #32, #35, #36.
Test plan
pytest CompStats— 74 passed