[REFACTOR] Move master.ini templates and their reader to Init component#11766
Open
chfsx wants to merge 1 commit into
Open
[REFACTOR] Move master.ini templates and their reader to Init component#11766chfsx wants to merge 1 commit into
chfsx wants to merge 1 commit into
Conversation
The ilias.master.ini.php / client.master.ini.php templates and their sole
consumer ilIniFilesPopulatedObjective lived in the Setup component
(formerly setup_). They seed the ilias.ini.php / client.ini.php written
during installation - an Init/environment concern - so both the templates
and the objective belong in the Init component.
Moved:
- components/ILIAS/Setup/{ilias,client}.master.ini.php
-> components/ILIAS/Init/resources/
- components/ILIAS/Setup/classes/class.ilIniFilesPopulatedObjective.php
-> components/ILIAS/Init/classes/
The objective now reads its templates same-component via
dirname(__DIR__) . '/resources/...'. All other __DIR__ based paths keep
working because Init/classes has the same nesting depth as Setup/classes.
The class stays in the global namespace, so its many callers across
components resolve unchanged via the classmap. composer.json classmap
excludes updated to the new template locations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ilias.master.ini.php / client.master.ini.php templates and their sole consumer ilIniFilesPopulatedObjective lived in the Setup component (formerly setup_). They seed the ilias.ini.php / client.ini.php written during installation - an Init/environment concern - so both the templates and the objective belong in the Init component.