Refactor/ilias3 sql to database#11765
Open
chfsx wants to merge 1 commit into
Open
Conversation
The ilias3.sql database dump template lived in the Setup component (formerly setup_). It is the database template consumed exclusively by the Database setup (ilDatabaseSetupConfig / ilDatabasePopulatedObjective), so it belongs in the Database component. Moved components/ILIAS/Setup/sql/ilias3.sql to components/ILIAS/Database/sql/ilias3.sql and updated all path references: ilDatabaseSetupConfig::DEFAULT_PATH_TO_DB_DUMP, ilDBUpdate custom updates path, composer.json classmap exclude, PHP-CS-Fixer exclude and .gitignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By consolidating two components Setup and setup_, I found that IMO the Database template should be moved to
Database.