[FIX] OIDC: Comply with RP-Initiated Logout 1.0 on OpenID Connect glo…#11762
Draft
mjansenDatabay wants to merge 1 commit into
Draft
[FIX] OIDC: Comply with RP-Initiated Logout 1.0 on OpenID Connect glo…#11762mjansenDatabay wants to merge 1 commit into
mjansenDatabay wants to merge 1 commit into
Conversation
…bal logout This commit fixes global OpenID Connect logout so it complies with [OpenID Connect RP-Initiated Logout 1.0](https://openid.net/specs/openid-connect-rpinitiated-1_0.html#RPLogout) Previously, ILIAS sent a dynamic `post_logout_redirect_uri` built via `ilStartUpGUI::logoutUrl()`, including CSRF `rtoken` and user-specific `lang` parameters. According to the specification, this URI **must exactly match** a value previously registered with the OpenID Provider. Strict OPs therefore rejected the logout request. The fix sends a **static, registerable** redirect URI (`/openidconnect.php`, same endpoint as login) and moves dynamic logout context into the ILIAS session. The optional `state` parameter is used as defined by the spec to correlate the OP callback with the pending logout. See: https://mantis.ilias.de/view.php?id=48027
mjansenDatabay
force-pushed
the
hotfix/10/48001
branch
from
July 16, 2026 11:19
3354bac to
e567ba4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…bal logout
This commit fixes global OpenID Connect logout so
it complies with OpenID Connect RP-Initiated Logout 1.0 Previously, ILIAS sent a dynamic
post_logout_redirect_uribuilt viailStartUpGUI::logoutUrl(), including CSRFrtokenand user-specificlangparameters.According to the specification, this URI must exactly match a value previously registered with the OpenID Provider. Strict OPs therefore rejected the logout request.
The fix sends a static, registerable redirect URI (
/openidconnect.php, same endpoint as login) and moves dynamic logout context into the ILIAS session. The optionalstateparameter is used as defined by the spec to correlate the OP callback with the pending logout.See: https://mantis.ilias.de/view.php?id=48027