fix: preserve blocked status of course members in updateCourse SOAP call (0040575)#11602
Open
sKarki999 wants to merge 1 commit into
Open
fix: preserve blocked status of course members in updateCourse SOAP call (0040575)#11602sKarki999 wants to merge 1 commit into
sKarki999 wants to merge 1 commit into
Conversation
GitHamo
approved these changes
May 27, 2026
Contributor
GitHamo
left a comment
There was a problem hiding this comment.
Looks good, I have tested it, but during my testing, I found that all the checkboxes are unchecked, not just blocked users. Maybe this ticket scope should be widened or a new separate ticket for it.
The issue occurs on trunk as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue outlined in Mantis #0040575, where blocked course members were silently unblocked after a
updateCourseSOAP call.Steps to Reproduce
addCourseSOAP call)updateCoursevia SOAP using the XML in Scenario 1 belowTest Scenarios
Scenario 1: Settings-only XML (no
<Members>block)Expected: Blocked user remains blocked after update.
Scenario 2: XML explicitly sends
blocked="No"Expected: User is unblocked
Scenario 3: XML sends
action="Detach"(user removed, not re-blocked)Expected: User is removed from course
If approved, must be picked for 11 and trunk.