Skip to content

[FIX] #47810 UI: Fix Ordering Table Dialog Open and Close #11577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matheuszych wants to merge 1 commit into
base: release_11
Choose a base branch
from
Open

[FIX] #47810 UI: Fix Ordering Table Dialog Open and Close #11577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/ILIAS/UI/src/templates/default/Table/tpl.orderingtable.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,16 @@

<div class="c-table-data__async_modal_container"></div>

<div class="c-table-data__async_message modal" role="dialog" id="{ID}_msgmodal">
<dialog class="c-table-data__async_message c-modal" id="{ID}_msgmodal">
<div class="modal-dialog" role="document">
<div class="modal-content">
<div class="modal-header">
<button type="button" class="close" data-dismiss="modal" aria-label="close"><span aria-hidden="true">&times;</span></button>
<form><button formmethod="dialog" class="close" aria-label="close"><span aria-hidden="true">&times;</span></button></form>
</div>
<div class="c-table-data__async_messageresponse modal-body"></div>
</div>
</div>
</div>
</dialog>
<!-- BEGIN warning_dialog -->
<dialog class="c-modal c-table-data__multiaction-warning" id="{ID}_warningmodal">
<div class="modal-dialog" role="document">
Expand Down
7 changes: 3 additions & 4 deletions components/ILIAS/UI/tests/Component/Table/OrderingRendererTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,17 +109,16 @@ public function getRows(
</table>
</form>
<div class="c-table-data__async_modal_container"></div>
<div class="c-table-data__async_message modal" role="dialog" id="id_1_msgmodal">
<dialog class="c-table-data__async_message c-modal" id="id_1_msgmodal">
<div class="modal-dialog" role="document">
<div class="modal-content">
<div class="modal-header">
<button type="button" class="close" data-dismiss="modal" aria-label="close">
<span aria-hidden="true">&times;</span></button>
<form><button formmethod="dialog" class="close" aria-label="close"><span aria-hidden="true">&times;</span></button></form>
</div>
<div class="c-table-data__async_messageresponse modal-body"></div>
</div>
</div>
</div>
</dialog>
</div>
EOT;
$this->assertEquals($this->brutallyTrimHTML($expected), $this->brutallyTrimHTML($actual));
Expand Down
Loading