Skip to content

Bring 2_cameras manifests into conformance with presentation-validator#77

Merged
gjcope merged 4 commits into
mainfrom
fix-camera-manifests
May 15, 2026
Merged

Bring 2_cameras manifests into conformance with presentation-validator#77
gjcope merged 4 commits into
mainfrom
fix-camera-manifests

Conversation

@vincentmarchetti
Copy link
Copy Markdown
Contributor

Manifest files were edited to eliminate errors identified by the presentation-validator

Validation errors that have been fixed were primarily replacing Annotation target values tha were strings with values that were JSON objects; for these manifests the targets were Scene resources.

Adding https schema ids to resources that didnt' have them, primarily SpecificResource objects

@vincentmarchetti vincentmarchetti requested a review from gjcope May 15, 2026 11:01
Copy link
Copy Markdown
Contributor

@gjcope gjcope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Manifests still work as before in Voyager and X3DOM viewers.

@gjcope gjcope merged commit bef1bd4 into main May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants