-
Notifications
You must be signed in to change notification settings - Fork 8
Remove fastly dependency from trusted-server-core (PR 15) #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/edgezero-pr14-entry-point-dual-path
Are you sure you want to change the base?
Changes from all commits
6c4965b
f67be31
c2e0776
25bcf99
8303b84
76087e4
7795e69
abd1f26
d96dbbe
8f40601
9a4357c
46704c0
60611fa
02639db
d8060d3
3a53f33
54d191b
2e128f7
f5b7097
725ccdc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,10 @@ log-fastly = { workspace = true } | |
| serde = { workspace = true } | ||
| serde_json = { workspace = true } | ||
| trusted-server-core = { workspace = true } | ||
| url = { workspace = true } | ||
| urlencoding = { workspace = true } | ||
| trusted-server-js = { path = "../js" } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🌱 seedling — Likely a leftover from PR15's adapter-side surgery; safe to drop. Same finding as the Apr 30 review. |
||
|
|
||
| [dev-dependencies] | ||
| bytes = { workspace = true } | ||
| edgezero-core = { workspace = true, features = ["test-utils"] } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌱 seedling —
trusted-server-js = { path = "../js" }is in the adapter's[dependencies]but never imported by adapter source. The adapter callshandle_tsjs_dynamicfromtrusted_server_core, which already pulls trusted-server-js transitively. Likely a leftover from PR15's adapter-side surgery. Removing this line should be a no-op for build/test and trims the dep graph.