SCENARIO: Simplified Media Insertion (see #365).#394
Conversation
benel
left a comment
There was a problem hiding this comment.
Thank you for your pull request @Hypertopic/tutos.
To improve other scenarios to come, please read commented lines.
Please note also that commit titles should be very strictly named (check Moodle for the rules to apply).
For this particular enhancement, there is a far simpler way to think about this improvement: see what I wrote on the issue discussion (#365). You will see that the scenario (and tests and implementation) will be far easier to update.
You only have to change one line in this scenario.
|
Please note that your git history will have to be edited so that, for scenarios, you have:
I strongly recommend using Git Fork for the intensive git history rewriting done in IF05. |
|
Thank you for your contribution @NourhaneBoudaoud @ZHENG-Qi625 Please don't forget that your pull request won't be integrated if your commits they don't follow strict naming conventions. It is quite easy with Git-Fork. See how it was done for a different issue: #390 (comment) Please note that the videos also show how |
|
@NourhaneBoudaoud @ZHENG-Qi625 Don't forget to fix your Git history as well as to fill your license term agreement. |
Co-authored-by: Nourhane BOUDAOUD nourhane.boudaoud@utt.fr Co-authored-by: Qi ZHENG qi.zheng@utt.fr Co-authored-by: Zhenpeng LI zhenpeng.li@utt.fr
Co-authored-by: Nourhane BOUDAOUD nourhane.boudaoud@utt.fr Co-authored-by: Qi ZHENG qi.zheng@utt.fr Co-authored-by: Zhenpeng LI zhenpeng.li@utt.fr
benel
left a comment
There was a problem hiding this comment.
Thank you for the update, @NourhaneBoudaoud @ZHENG-Qi625
It is better than it was, but please have a look at my inline comments.
Don't forget also to put all your edits of jsx files in the same IMPROVEMENT commit.
| Fonctionnalité: Insérer dans un document une vidéo | ||
| Fonctionnalité: Insérer dans un document une vidéo sur YouTube | ||
|
|
||
| Scénario: provenant de YouTube |
There was a problem hiding this comment.
Please don't change those 2 lines since we hope, one day, to be compatible also with Dailymotion, Pod, etc.
|
|
||
| function FormattedText({children, setHighlightedText, selectable, setSelectedText}) { | ||
|
|
||
| function FormattedText({ children, setHighlightedText, selectable, setSelectedText }) { |
There was a problem hiding this comment.
Please never commit format change (like spaces), it breaks "git blame" and generates unnecessary edition conflicts when rebasing branch.
| }; | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
Please never commit format change (like line break and indentation), it breaks "git blame" and generates unnecessary edition conflicts when rebasing branch, and make code review far more long and complex.
| return ( | ||
| <iframe width="80%" height="300" src={embedLink} frameBorder="0" allowFullScreen></iframe> | ||
| ); | ||
| return <iframe width="80%" height="300" src={embedLink} style={{ border: 0 }} allowFullScreen title="YouTube video" />; |
There was a problem hiding this comment.
Please never commit format change (like line break, parenthesis and indentation), it breaks "git blame" and generates unnecessary edition conflicts when rebasing branch, and make code review far more long and complex.
Co-authored-by: Nourhane BOUDAOUD nourhane.boudaoud@utt.fr
Co-authored-by: Qi ZHENG qi.zheng@utt.fr
Co-authored-by: Zhenpeng LI zhenpeng.li@utt.fr
We, Nourhane BOUDAOUD, Qi ZHENG & Zhenpeng LI hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.