Feature/add order-notes query logging#45
Open
mrtwebdesign wants to merge 1 commit into
Open
Conversation
Add a pre_get_comments probe that records a backtrace for unscoped wc_get_order_notes() loads -- the "order-notes mega-query" that selects every order note via WHERE comment_ID IN (...) when called with no order_id/order__in. The slow-query classifier already flags that such a query ran, but its caller field stops at wc-order-functions.php; this probe fires before the query executes and captures the upstream caller, so the offending plugin/column/export that omits the order scope can be identified. Gated by HYPERCART_QUERY_GUARD_LOG_ORDER_NOTES (off by default) and the hypercart_query_guard_log_order_notes filter; when disabled the hook is never registered. Volume bounded three ways: non-order-note comment queries return immediately, scoped per-order loads are ignored, and a per-request cap guards against a looping caller. Emits an order_notes_unscoped event through the existing self::log() pipeline. Bumps version to 1.2.0 and documents the constant in the plugin header. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mrtwebdesign
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opti-in logging to capture mega-query error source