Skip to content

Add open access flag - #125

Open
jeremiah-kang wants to merge 1 commit into
HydrologicEngineeringCenter:mainfrom
jeremiah-kang:add-readonly-open
Open

Add open access flag#125
jeremiah-kang wants to merge 1 commit into
HydrologicEngineeringCenter:mainfrom
jeremiah-kang:add-readonly-open

Conversation

@jeremiah-kang

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread src/hecdss/hecdss.py
"""bool: True when this file was opened with DssAccess.READ_ACCESS"""
return self._access == DssAccess.READ_ACCESS

def _check_writable(self, operation: str) -> None:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider _asssert_writable

Comment thread src/hecdss/dss_access.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider naming this without dss prefix, because we are inside dss already. perhaps Access , or OpenAccess, or...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants