Skip to content

a11y(blocks): render collection/markdown section titles as <h2> #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vidminas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

a11y(blocks): render collection/markdown section titles as <h2> #3344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/blox/blox/content-collection/block.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,9 @@
{{ if $title }}
<div class="flex flex-col items-center max-w-prose mx-auto gap-3 justify-center px-6 md:px-0">

<div class="mb-6 text-3xl font-bold text-gray-900 dark:text-white">
<h2 class="mb-6 text-3xl font-bold text-gray-900 dark:text-white">
{{ $title }}
</div>
</h2>

{{ with $text }}<p>{{ . }}</p>{{ end }}
</div>
Expand Down
4 changes: 2 additions & 2 deletions modules/blox/blox/markdown/block.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
<div class="flex flex-col items-center max-w-prose mx-auto gap-3 justify-center px-6">

{{ with $title }}
<div class="mb-6 text-3xl font-bold text-gray-900 dark:text-white">
<h2 class="mb-6 text-3xl font-bold text-gray-900 dark:text-white">
{{ . }}
</div>
</h2>
{{ end }}

{{/* We use DIV rather than P to support `prose` class and multiple paragraphs */}}
Expand Down