fix(footer): remove duplicated opening <a> in CC license icons#3330
Open
Vidminas wants to merge 1 commit into
Open
fix(footer): remove duplicated opening <a> in CC license icons#3330Vidminas wants to merge 1 commit into
Vidminas wants to merge 1 commit into
Conversation
The Creative Commons icon link rendered two identical opening `<a>` tags followed by a single closing `</a>`, producing invalid nested-anchor HTML. Delete the duplicate opening tag. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
β Deploy Preview for academic-demo canceled.
|
Contributor
|
Wow, your first PR! Welcome to the community! π Thank you for this contribution to open source and open research. It makes a huge impact for the thousands of innovators building with Hugo Blox. If you're wondering about next steps, please read our Contributor Guide for coding standards, how to run the project locally, and how to get help. We hope this is just the start of your journey with us. Let's build the future together! Join us on Discord to connect with the team and community. Awesome work, we'll take a look soon! β¨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Creative Commons icon link rendered two identical opening
<a>tags followed by a single closing</a>, producing invalid nested-anchor HTML. Delete the duplicate opening tag.π What type of change is this?
π― What is the purpose of this change?
The footer Creative-Commons license icons open with two identical
<a>tags but close witha single
</a>(site_footer_license.html), producing invalid nested-anchor HTML. Browsersrecover from it, but it's malformed markup and can confuse assistive tech and validators. I caught this during keyboard navigation accessibility testing.
Fix. Delete the duplicate opening
<a>.Verified on the
academic-cvstarter: the built footer now contains exactly onearia-label="Creative Commons"anchor with zero nested<a><a>sequences.πΈ Screenshots or Screencast (if applicable)
n/a β no visual change; the fix is valid HTML (
<a><a><svg>β¦β<a><svg>β¦).βΉοΈ Documentation Check
π Contributor Agreement
Thank you for your contribution!