Skip to content

fix(footer): remove duplicated opening <a> in CC license icons#3330

Open
Vidminas wants to merge 1 commit into
HugoBlox:mainfrom
Vidminas:fix/footer-license-dup-anchor
Open

fix(footer): remove duplicated opening <a> in CC license icons#3330
Vidminas wants to merge 1 commit into
HugoBlox:mainfrom
Vidminas:fix/footer-license-dup-anchor

Conversation

@Vidminas

Copy link
Copy Markdown

The Creative Commons icon link rendered two identical opening <a> tags followed by a single closing </a>, producing invalid nested-anchor HTML. Delete the duplicate opening tag.

πŸš€ What type of change is this?

  • πŸ› Bug fix (A non-breaking change that fixes an issue)
  • ✨ New feature (A non-breaking change that adds functionality)
  • πŸ’… Style change (A change that only affects formatting, visuals, or styling)
  • πŸ“š Documentation update (Changes to documentation only)
  • 🧹 Refactor or chore (A code change that neither fixes a bug nor adds a feature)
  • πŸ’₯ Breaking change (A fix or feature that would cause existing functionality to not work as expected)

🎯 What is the purpose of this change?

The footer Creative-Commons license icons open with two identical <a> tags but close with
a single </a> (site_footer_license.html), producing invalid nested-anchor HTML. Browsers
recover from it, but it's malformed markup and can confuse assistive tech and validators. I caught this during keyboard navigation accessibility testing.

Fix. Delete the duplicate opening <a>.

Verified on the academic-cv starter: the built footer now contains exactly one aria-label="Creative Commons" anchor with zero nested <a><a> sequences.


πŸ“Έ Screenshots or Screencast (if applicable)

n/a β€” no visual change; the fix is valid HTML (<a><a><svg>… β†’ <a><svg>…).


ℹ️ Documentation Check

  • No, this change does not require a documentation update.
  • Yes, I have updated the documentation accordingly (or will in a follow-up PR).

πŸ“œ Contributor Agreement

Thank you for your contribution!

The Creative Commons icon link rendered two identical opening `<a>` tags
followed by a single closing `</a>`, producing invalid nested-anchor HTML.
Delete the duplicate opening tag.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Vidminas
Vidminas requested a review from gcushen as a code owner July 10, 2026 07:37
@netlify

netlify Bot commented Jul 10, 2026

Copy link
Copy Markdown

βœ… Deploy Preview for academic-demo canceled.

Name Link
πŸ”¨ Latest commit 7f10547
πŸ” Latest deploy log https://app.netlify.com/projects/academic-demo/deploys/6a50a12699ac0e00087ec240

@github-actions

Copy link
Copy Markdown
Contributor

Wow, your first PR! Welcome to the community! πŸŽ‰

Thank you for this contribution to open source and open research. It makes a huge impact for the thousands of innovators building with Hugo Blox.

If you're wondering about next steps, please read our Contributor Guide for coding standards, how to run the project locally, and how to get help.

We hope this is just the start of your journey with us. Let's build the future together! Join us on Discord to connect with the team and community.

Awesome work, we'll take a look soon! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant