fix: exclude Slack's reserved mention keywords from people extraction - #56
Open
chrissanchez-iops wants to merge 1 commit into
Open
chrissanchez-iops wants to merge 1 commit into
chrissanchez-iops wants to merge 1 commit into
Conversation
Knowledge-mode's @mention person detector was matching @here, @channel, etc. as people whenever docs describe Slack mention syntax in prose (not just code spans) -- e.g. "Use <!here> not @here" or "Always @mention people". These are Slack's own reserved keywords and can never be a real handle in any project, same class of fix already applied to JSDOC_TAGS/CSS_AT_RULES above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Knowledge-mode's
@mentionperson detector matches@here,@channel, etc. aspeople whenever docs describe Slack mention syntax in prose, not just code spans
<!here>not@here" or "Always @mention people by Slack user ID".These are Slack's own reserved keywords and can never be a real handle in any
project's docs — same class of false positive
JSDOC_TAGS/CSS_AT_RULESalreadyguard against just above this in the file.
Found while running
--mode knowledgeagainst a real internal memory/notesdirectory:
hereshowed up in the extracted People list alongside actualcontent.
Test plan
npm run build), reran--mode knowledgeagainst the samefixture directory —
@hereno longer appears inPeople, unrelatedgeneric-word false positives (
@mention,@team) are unchanged (out ofscope for this fix — no clean general rule distinguishes those from a
real handle without a dictionary check)