Open
Conversation
Sorbet's runtime `validate_call` uses `bind_call` to invoke the original `formulae_by_full_name` method, bypassing RSpec mocks. Replace the mock with a real formula that declares `conflicts_with "mysql55"` via `stub_formula_loader`.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a flaky conflicts_with spec by avoiding an RSpec mock that can be bypassed by Sorbet runtime validate_call, and instead using a real stubbed formula definition that exposes conflicts_with through the normal code path.
Changes:
- Replace
formulae_by_full_namemocking withstub_formula_loader+ a stub formula declaringconflicts_with "mysql55". - Keep the rest of the install/upgrade/service expectations unchanged while making the spec exercise the real formula hashing path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorbet's runtime
validate_callusesbind_callto invoke the originalformulae_by_full_namemethod, bypassing RSpec mocks. Replace the mock with a real formula that declaresconflicts_with "mysql55"viastub_formula_loader.brew lgtm(style, typechecking and tests) with your changes locally?Claude Code with manual verification and testing.