Implement sin and cos#4
Merged
Merged
Conversation
Member
|
Thanks! This looks great, the only things this needs are tests. I've added a general-purpose harness in #5 and improved it in #6. (Note that the implementation of If you rebase this PR on current |
`sin` and `cos` of a `GVar` return the exact first three moments of the transformed Gaussian, obtained from its characteristic function, and propagate the reliability diagnostics as `exp` does. `sincos` returns the pair. Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
sinandcosforGVar. Since the resulting distributions are not Gaussians, these will return a newGVarthat approximates the target distribution by matching its mean and variance.One thing to note is that the center of
sin(a)is not necessarily equal tosin(a.center)(and the same goes forcos). A derivation and some tests of the result against empirical solutions can be found here.