Close ThickNumbers interface gaps#11
Merged
Merged
Conversation
Report `mid`, `wid` and `rad` from the stored `center` and `σ` rather than deriving them from `loval`/`hival`. The round-trip through `center ± σ` loses an ulp, which could push `rad` below the radius handed to `midrad` and break its containment contract. Add `log2`, `log10`, `exp2` and `exp10`, defined by rescaling to the natural base (exact under the constant-factor rules). Define `^(::GVar, ::Rational)` to resolve the ambiguity with Base's `^(::Number, ::Rational)`. Test conformance against the shared ThickNumbersInterfaceTests suite, and add Aqua and ForwardDiff checks. Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 199 207 +8
=========================================
+ Hits 199 207 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Exercise `^(::GVar, ::Rational)` and `wid(::GVar)`, which the existing suite never reached. Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report
mid,widandradfrom the storedcenterandσrather than deriving them fromloval/hival. The round-trip throughcenter ± σloses an ulp, which could pushradbelow the radius handed tomidradand break its containment contract.Add
log2,log10,exp2andexp10, defined by rescaling to the natural base (exact under the constant-factor rules).Define
^(::GVar, ::Rational)to resolve the ambiguity with Base's^(::Number, ::Rational).Test conformance against the shared ThickNumbersInterfaceTests suite, and add Aqua and ForwardDiff checks.
Assisted-by: Claude Opus 4.8 noreply@anthropic.com