Thread Changes Cleanup#1345
Open
Aidan63 wants to merge 7 commits into
Open
Conversation
added 7 commits
May 24, 2026 13:56
also change ifdef end to still include atomic
already virtual on the base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains various bits of cleanup related to the c++11 threading changes from the last few merges.
__hxcpp_functions are now excluded unless building for haxe 4 (it's a shame we can't conditionally remove that old Thread.cpp file from the build xml).HxCreateDetachedThreadhave been replaced with a detachedstd::threadso that function can be removed.std::this_thread::sleep_foris now used internally instead of#ifdef's for various OS'HXCPP_THREAD_XMLdefine to point to a build xml file which will provide implementations for thehx::threadapi instead of the built in one.Scratchtype which was added in the typed thread PR.I've put some more thoughts on the structure of these threading changes in this issue #1279