Harden placeholder and scoreboard rendering - #74
Merged
Conversation
remdui
marked this pull request as ready for review
July 27, 2026 23:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
RuntimeExceptionand binary-incompatibilityLinkageErrorfailures from PlaceholderAPI expansionsnull%vault_eco_*%placeholdersRoot cause
PlaceholderAPI was called without an exception boundary. A disabled or binary-incompatible economy expansion could therefore escape through localization rendering into
PlayerJoinEventand the repeating scoreboard task. The task then failed every refresh interval, producing repeated stack traces and preventing scoreboard updates.Behaviour after this change
Broken expansions no longer escape into Bukkit lifecycle events or scheduler tasks. Their placeholders remain visibly unresolved rather than crashing the message. When Vault has no usable economy provider, only Vault economy placeholders are held back; unrelated placeholders continue to resolve. A failure for one scoreboard line or one player does not stop remaining lines or players.
Tests
Added regression coverage for:
CI runs the complete Maven verification and bundled Paper acceptance suites for the published branch.