Fix Paper shared connection access before plugin enable - #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PluginDisableEventwhile invalidating the disabled plugin's active identity and unregistering its database handles.Root cause
Paper previously treated only already-enabled plugins as known. DataRegistry requests
player_data_rwbefore ServerFeatures enables, so the validshared_with: [ServerFeatures]declaration was rejected as referencing an unknown plugin. Velocity already discovers installed plugins before plugin work begins, which is why ProxyFeatures did not encounter the same failure.Security model
Configuration knowledge and caller authority are deliberately separate:
Production configuration
This resolves both observed startup modes: DataRegistry no longer rejects the policy with
InvalidConnectionAccessPolicyException, and ServerFeatures is no longer denied withConnectionAccessDeniedException.