-
Notifications
You must be signed in to change notification settings - Fork 0
Observability for Harper binary resolution + loopback setup verification #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
heskew
wants to merge
4
commits into
main
Choose a base branch
from
fix/resolution-observability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−5
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
aacdfca
feat(startup): log the resolved Harper binary and warn on node_module…
heskew cb4fc98
fix(setup-loopback): verify aliases landed before reporting success
heskew c17d928
fix(setup-loopback): announce the range up front; capture ifconfig ou…
heskew 154cba3
feat(startup): walk ancestors for the local-build warning (review)
heskew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The success check can still accept the configuration this script is meant to repair. If an old
127.0.0.$ialias has a/8netmask and either the delete or re-add fails (those statuses are currently ignored), the old alias remains inLO0_STATE; this IP-only grep passes and prints ✓ even though the overlapping-subnet/mDNS CPU problem remains. Could the verifier require the matching alias to havenetmask 0xffffffff(macOS's representation of/32) before reporting success? Checking/reporting a failed add would also make the immediate error clearer. A fake-ifconfigregression test with an existing/8alias would lock this down.