Skip to content

Mohamad Bader AA#2

Open
noneeeed wants to merge 3 commits intoHackYourAssignment:mainfrom
noneeeed:main
Open

Mohamad Bader AA#2
noneeeed wants to merge 3 commits intoHackYourAssignment:mainfrom
noneeeed:main

Conversation

@noneeeed
Copy link
Copy Markdown

@noneeeed noneeeed commented Apr 8, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

📝 HackYourFuture auto grade

Assignment Score: 0 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 0
🧪 The auto grade is experimental and still being improved

Test Details

with:
node-version: "24"
cache: "npm"
cache-dependency-path: task-1/package-lock.json
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you choose to add this configuration?

cache-dependency-path: task-1/package-lock.json

- name: Install dependencies
run: npm ci
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of npm ci!

Do you know the difference between this and npm install?

with:
name: weather-app-dist
path: task-1/dist/
retention-days: 5
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 This is really good choice. Imagining that you have multiple PR merges and big teams, you should think about storage, because it has a cost and limit.

Copy link
Copy Markdown

@rafasilpereira rafasilpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👏

Good choices made when thinking about CI with npm ci and retention days!

Very good commit messages as well! Makes it clear you thought and development process and helps other developers when reviewing your code

@rafasilpereira rafasilpereira added the Reviewed This assignment has been reivewed by a mentor and a feedback has been provided label Apr 15, 2026
@rafasilpereira rafasilpereira self-assigned this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants