Handle escaped pipes in README table parsers#107
Merged
Jose-Gael-Cruz-Lopez merged 1 commit intoJul 13, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Jose-Gael-Cruz-Lopez
added a commit
to ChimdumebiNebolisa/hackhq
that referenced
this pull request
Jul 13, 2026
Resolves the conflict with Hack-HQ#107 (both PRs appended a test class at the same spot in test_scripts.py). Kept both: SplitTableCells from main, plus this PR's ResolveState and CloseOpportunityState. util.py auto-merged cleanly, so Hack-HQ#107's split_table_cells and this PR's resolve_state change both survive. Also closes the gap this PR left open. It made util.resolve_state check active is False FIRST, but the web deriveState still checked opens_soon first, so a listing with state=opens_soon + active=false rendered CLOSED in the README and OPENS SOON on the site. Reordered deriveState so closed wins over opens_soon, matching resolve_state, and added a parity regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parse markdown table rows on unescaped pipe delimiters so escaped
\|cell content does not shift columns.Problem
The README generator escapes literal pipes as
\|, but parsers split on every raw|character. A pipe in host, title, location, or prize corrupts or drops the row.Changes
split_table_cellshelper inutil.pyweekly_digest.pyandgenerate_banner.pysplitTableCellsinparse-readme.tsfor the frontend parserValidation
python -m unittest discover -s .github/scripts -p "test_*.py"- 50 tests OKnpm testinweb/- 52 tests OKScope
No change to pipe-free rows.
closing_soon.pyalready used unescaped-pipe splitting.