Set structured state when closing a listing#106
Open
ChimdumebiNebolisa wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set canonical
state: closedwhen closing a listing and makeresolve_statehonoractive: false.Problem
handle_close_opportunityonly setactive: false. README generation usesresolve_state, which previously returned the storedstatefield first, so a listing closed via automation could still render as OPEN in the README while the website showed it closed.Changes
statetoclosedin the close handleractive is Falseas closed inresolve_stateValidation
python -m unittest discover -s .github/scripts -p "test_*.py"- 54 tests OKScope
No README or listings.json churn; repairs future close operations and any inconsistent records where
activeis false butstateis not closed.