fix(event-display): fix track 'Color by' when loading JSON with linke… - #978
Open
valponce wants to merge 1 commit into
Open
fix(event-display): fix track 'Color by' when loading JSON with linke…#978valponce wants to merge 1 commit into
valponce wants to merge 1 commit into
Conversation
…d tracks after one without
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to reproduce the bug :
Issue :
When loading the new JSON file, a new Phoenix menu node is created based on the new data and compared against the previous menu node (see
loadStateFromJSON()inphoenix-menu-node.ts). For each configuration with the same label and type, the previous configuration's properties are kept, except for the propertyoptions, where the new one is adopted.Consequently, for the "Color by" configuration (created in
color-options.ts), the old version of theonChangefunction was retained instead of using the new one. However, this function relies on thecolorByOptionsattribute, which did not contain a "Vertex" option during the initial load since the data lacked linked tracks. Therefore, when switching "Color by" to Vertex in the new load, nothing happens.Fix :
Keep not only the property
options, but also the propertyonChange.