Feat: Implement dynamic folder icon and use to game directory list#6435
Feat: Implement dynamic folder icon and use to game directory list#6435KSSJW wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new filled folder icon (FOLDER_FILL) and updates GameDirectoryListItemSkin to dynamically switch between the standard and filled folder icons based on the item's selection state. Feedback suggests optimizing this state change by checking if the icon has actually changed before calling left.setIcon, which prevents redundant cross-fade animations and saves CPU/GPU resources.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a filled folder icon (FOLDER_FILL) and updates the GameDirectoryListItemSkin to dynamically switch between the outline and filled folder icons based on the selection state of the directory item, using a short transition animation. The review feedback suggests initializing the icon based on the initial selection state of the directory item to prevent an unnecessary transition animation during the initial UI rendering.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new filled folder icon (FOLDER_FILL) and updates the game directory list item skin (GameDirectoryListItemSkin) to dynamically transition between the outline and filled folder icons based on the selection state. The reviewer suggested using skinnable.isSelected() instead of skinnable.selectedProperty().get() to align with JavaFX conventions and improve readability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
en? gemini不应该是停止这个审查代码的服务了吗? 怎么还能用? |
不知道（ |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3 participants
添加
FOLDER_FILL图标并且应用于游戏文件夹实况
_20260719_144329.mp4