Skip to content

Fix: Resolve ModLoaderType.LEGACY_FABRIC for Modrinth#6434

Merged
Glavo merged 1 commit into
HMCL-dev:mainfrom
KSSJW-Contribution:legacy-fabric-tag
Jul 18, 2026
Merged

Fix: Resolve ModLoaderType.LEGACY_FABRIC for Modrinth#6434
Glavo merged 1 commit into
HMCL-dev:mainfrom
KSSJW-Contribution:legacy-fabric-tag

Conversation

@KSSJW

@KSSJW KSSJW commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

补充 Modrinth 数据源的 Legacy Fabric 标签解析

实况

更改前 更改后
1 2

@github-actions github-actions Bot added the 1+ label Jul 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the Legacy Fabric mod loader. It updates the UI download page to handle the LEGACY_FABRIC case and display its tag, and maps the legacy-fabric loader string to the ModLoaderType.LEGACY_FABRIC enum in the Modrinth repository. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@KSSJW

KSSJW commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

Code Review

This pull request introduces support for the Legacy Fabric mod loader. It updates the UI download page to handle the LEGACY_FABRIC case and display its tag, and maps the legacy-fabric loader string to the ModLoaderType.LEGACY_FABRIC enum in the Modrinth repository. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026. For more details on the timeline and next steps, please review the Help Documentation.

哈基mi你这家伙居然还活着(

@gemini-code-assist

Copy link
Copy Markdown
Contributor

感谢你的关注!虽然 Gemini Code Assist 服务即将停止,但很高兴看到这个 PR 能够顺利解决 Modrinth 数据源中 Legacy Fabric 的解析问题。代码实现看起来很清晰,逻辑也很准确。祝项目开发顺利!

@KSSJW KSSJW left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@KSSJW
KSSJW marked this pull request as ready for review July 18, 2026 18:27
@Glavo

Glavo commented Jul 18, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 1390455e4d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Glavo
Glavo merged commit c1407a9 into HMCL-dev:main Jul 18, 2026
3 checks passed
@KSSJW
KSSJW deleted the legacy-fabric-tag branch July 19, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants