支持置顶日志窗口#6101
Conversation
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
|
在置顶状态下,如果按钮呈现一个鼠标悬停效果的话,效果可能会好一些。或者可以使用实心的图案代表置顶状态。 |
|
那个issue不是还想要透明效果吗 |
我感觉透明功能可以放到另一个 PR 里,这样好审。 |
我的意思是暂时不能把那个issue通过该pr关了 |
|
另外已经置顶后那个tip是不是应该换成“取消置顶”?以及这个置顶的效果在重新打开日志窗口后还会存在吗? |
实测似乎是一次性的,新窗口要再次手动开启。 |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces an "Always On Top" toggle button to the log window, allowing users to keep the log window pinned above other windows. This includes adding the toggle button, styling it with a rotation effect in CSS, adding a new SVG icon, and providing localization strings. The review feedback highlights a potential memory leak where a listener is added to the stage's alwaysOnTopProperty inside the Skin class. It is recommended to move this listener to the LogWindowImpl constructor to prevent leaks when the skin is recreated.
相关 issue #6077

