[Feature] 模组等的更新日志以及 HTMLRenderer 的完善#6098
Open
ToobLac wants to merge 135 commits into
Open
Conversation
# Conflicts: # HMCL/src/main/resources/assets/lang/I18N.properties # HMCL/src/main/resources/assets/lang/I18N_es.properties # HMCL/src/main/resources/assets/lang/I18N_ja.properties # HMCL/src/main/resources/assets/lang/I18N_lzh.properties # HMCL/src/main/resources/assets/lang/I18N_ru.properties # HMCL/src/main/resources/assets/lang/I18N_uk.properties # HMCL/src/main/resources/assets/lang/I18N_zh.properties # HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java
# Conflicts: # HMCL/src/main/resources/assets/about/deps.json
This reverts commit b62d8e3.
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/HTMLRenderer.java # HMCL/src/main/resources/assets/about/deps.json # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modrinth/ModrinthRemoteModRepository.java # gradle/libs.versions.toml
# Conflicts: # HMCL/src/main/resources/assets/about/deps.json # HMCLCore/build.gradle.kts # gradle/libs.versions.toml
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/AddonUpdatesPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalModFile.java # HMCLCore/src/main/java/org/jackhuang/hmcl/util/StringUtils.java
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a changelog viewing system for mods and addons, incorporating the CommonMark library for Markdown-to-HTML conversion and significantly upgrading the HTMLRenderer to support tables, code blocks, and asynchronous image loading. UI updates in AddonUpdatesPage and DownloadPage enable users to access changelogs and external version URLs. Feedback points out potential memory leaks in JavaFX property bindings to static controllers, code duplication across changelog dialog implementations, and the need for more robust error handling when generating repository URLs to prevent UI crashes.
Glavo
reviewed
May 29, 2026
Member
Glavo
left a comment
Glavo
left a comment
There was a problem hiding this comment.
本审查建议由 GPT-5 生成
已将具体审查建议标注在对应代码行。
Co-authored-by: CiiLu <109708109+ciilu@users.noreply.github.com>
Contributor
Author
|
现在需要重新解决表格过大的问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加了下载模组、数据包等以及更新模组时显示更新日志的功能
Resolves #4685
具体变化：
HTMLRenderer的优化与完善，以及对 Markdown 的支持（引入了新依赖）TODO：